[PoC] Implement response wrapper for ValidatorBalances #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this. There are a few other items that I'm looking at in conjunction with this change, as if we're going to alter the public API (which I think ultimately we will have to do with this alteration) then I'd rather that all of the relevant changes are in place so we don't change the function signatures multiple times. I'll push up a PR some time this week that has the various changes in place, to allow for feedback. |
This was referenced Oct 4, 2023
Merged
|
Thank you for your work on this; #80 has been merged so closing this item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept sketch for adding a generic response type which provides access to metadata. I intentionally picked an endpoint which had to make some decisions about how to handle chunking to get the ball rolling on discussion. There may be other questions to answer for some of the versioned endpoints as well.