Rework API #80
Merged
Rework API #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Willyham
reviewed
Oct 7, 2023
|
Left a few comments, I think this is definitely a good direction 👍 |
xenowits
reviewed
Oct 11, 2023
xenowits
reviewed
Oct 11, 2023
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
|
I'm relatively comfortable with the changes here, opening up for final review by interested parties prior to merging. |
Rename BeaconBlockBlobs to BlobSidecars.
xenowits
reviewed
Oct 18, 2023
xenowits
reviewed
Oct 18, 2023
| // String returns a string version of the structure. | ||
| func (v *VersionedProposal) String() string { | ||
| switch v.Version { | ||
| case spec.DataVersionBellatrix: |
There was a problem hiding this comment.
Why are we not checking for phase0 blocks?
There was a problem hiding this comment.
This was the result of a partial implementation during the move to using proposals. Should now be fully updated with all forks.
| // String returns a string version of the structure. | ||
| func (v *VersionedSignedProposal) String() string { | ||
| switch v.Version { | ||
| case spec.DataVersionBellatrix: |
There was a problem hiding this comment.
Here as well, I believe we should add a switch case for phase0 version
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
This was referenced Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of API to meet new requirements. Main points:
api.Response[T]wrapper to provide additional information with response dataThis is an alternative to #77 and has a wider scope. It also tidies up various rough edges that have existed in the implementation.
@Willyham please take a look and let me know what you think in terms of the changes. Note that these have not yet been applied across all APIs, that will be done prior to any merge but this should allow you to get the feel for the changes being made.