Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Management properties; add lazy-load methods #363

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Deprecate Management properties; add lazy-load methods #363

merged 3 commits into from
Sep 20, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Sep 17, 2019 •
edited
Loading

Changes

  • Add lazy-load methods for Management API class.
  • Deprecate public Management properties.

Note: These methods are being added to support switching over to methods instead of properties in 7.0.0. These do not currently lazy-load but allow developers to start upgrading their implementations before the upgrade.

Testing

  • This change adds test coverage
  • This change was developed in PHP 7.1

@joshcanhelp joshcanhelp requested a review from a team September 17, 2019 00:20
@joshcanhelp joshcanhelp added this to the 5.6.0 milestone Sep 17, 2019
@joshcanhelp joshcanhelp reopened this Sep 17, 2019
@joshcanhelp joshcanhelp force-pushed the lazy-load-management-api branch 2 times, most recently from d74641d to 0f59682 Compare September 18, 2019 20:30
@joshcanhelp joshcanhelp changed the title Add lazy-load Management methods Deprecate Management properties; add lazy-load methods Sep 20, 2019
@joshcanhelp joshcanhelp added large and removed medium labels Sep 20, 2019
@joshcanhelp joshcanhelp merged commit bee2bc6 into master Sep 20, 2019
@joshcanhelp joshcanhelp deleted the lazy-load-management-api branch September 20, 2019 18:49
@joshcanhelp joshcanhelp mentioned this pull request Oct 15, 2019
Merged
4 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @luisrudge