Update management props

[joshcanhelp]

Changes

This is a breaking change for Management API functionality.

Management class properties have been changed from public to private access. Instead of using the class property to access the endpoint functionality, you'll now use a method with the same (or very similar) name as the property.

You can see these changes in some of the tests below but, for clarity, if you were getting users like so:

$m_api = new Management( $api_token, $domain );
$results = $m_api->users->getAll();

... it would now be:

$m_api = new Management( $api_token, $domain );
$results = $m_api->users()->getAll();

Other changes:

• Management constructor declares parameter types
• Endpoint methods declare return types
• Removed unused protected setApiClient() method

References

#363 - Deprecation PR for properties

Testing

• This change modifies test coverage (removes the property type check)
• This change has been tested on PHP 7.1

Checklist

• All existing and new tests complete without errors.
• The correct base branch is being used.

[damieng]

What's the underlying rationale behind moving from properties to methods? (Our .NET management API uses properties)

[joshcanhelp]

@damieng - Properties could be accidentally set to something else and all endpoints are loaded at once, even if you just use one.

[damieng]

PHP doesn't let you do read-only properties or delayed loading? I guess they're more like instance variables than properties?

[joshcanhelp]

PHP doesn't let you do read-only properties?

Not really. You can define a a magic __get method and look for the property but ... methods work a little better. Would be boilerplate for either way.

... or delayed loading?

This package uses an auto-loader so, yes, but you have to instantiate individual classes. This Management class is the "router" of sorts so would have to re-architect a bit.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.