Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for XCode 12.5 #196

Merged
merged 2 commits into from
May 4, 2021
Merged

Fix for XCode 12.5 #196

merged 2 commits into from
May 4, 2021

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented May 3, 2021 •
edited
Loading

Changes

Since version 12.5 (released on 26 Apr 2021), Xcode no longer accepts an entire URL for the ASWebAuthenticationSession scheme value. This PR extracts the scheme from the URL and uses just that, instead of the whole URL.

References

Fixes #189

Same fix has been applied here auth0/react-native-auth0#369

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@frederikprijck frederikprijck marked this pull request as ready for review May 3, 2021 20:07
@frederikprijck frederikprijck requested a review from a team as a code owner May 3, 2021 20:07
@frederikprijck frederikprijck added review:tiny Tiny review CH: Fixed PR is fixing a bug labels May 3, 2021
@frederikprijck frederikprijck merged commit ac2e513 into master May 4, 2021
@frederikprijck frederikprijck deleted the fix/189 branch May 4, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug review:tiny Tiny review
Projects
None yet
Milestone
No milestone
2 participants
@frederikprijck @evansims