Fix for Xcode 12.5 [SDK-2545]

[Widcket]

Changes

Since version 12.5 (released on 26 Apr 2021), Xcode no longer accepts an entire URL for the ASWebAuthenticationSession scheme value. This PR extracts the scheme from the URL and uses just that, instead of the whole /authorize URL.

References

Fixes #360

Testing

• This change adds unit test coverage
• This change has been tested on the latest version of the platform/language or why not

Checklist

• I have read the Auth0 general contribution guidelines
• All existing and new tests complete without errors
• All active GitHub checks have passed

[norbertschuler]

I just verified that using this pull request solved my crash mention in #371. Would be great if a new release with the fix could be done to help people with iOS 14.5.

[idrisssakhi]

It would be great to have a new release. Because old version doesn’t work on IOS 14.5.

[adammcarth]

Thanks for getting this one in so quickly @Widcket. When can we expect this to be available as a release?

[Widcket]

@adammcarth I expect the release PR to be merged tomorrow, and then I'll push to npm.

[steven-pearson]

Will the publish also include an update to Nuget for Auth0.OidcClient.iOS?

[Widcket]

The release has been pushed to npm.

@steven-pearson this is only for react-native-auth0.

[smenke]

Thanks so much! This fixed the issue.

[Widcket]

@steven-pearson the update for Auth0.OidcClient.iOS is being tracked in auth0/auth0-oidc-client-net#189.

[prangel-credera]

Hi there,

I am encountering this issue but only seem to be able to replicate it on Emulator devices, not on deployed devices. Is that expected?

Thanks,
-Peter

[Widcket]

Hi @prangel-credera,
I'm able to replicate it on a physical device running iOS 14.5.

[sinclas]

Same error here. What is the easiest way to fix this on a developer machine? What are some workarounds? Thanks!!

[marf]

Same error here.

[sinclas]

HI,

This just for development, but got everything working and productive again:

I opened Xcode, located the A0Auth0.m file. Should be located in development pods.
locate the method - (void)presentAuthenticationSession:(NSURL *)URL
change: NSString *callbackURLScheme = queryItem.value;
to: NSString *callbackURLScheme = [[NSURL URLWithString: queryItem.value] scheme];

I had updated Xcode and iOS and had to make this change to keep productive. Will wait for an NPM update prior to doing anything in test or release. ;)

S

[relm923]

The fix was released in 2.8.2. Are you still seeing issues with the latest version? Its working for our team with 14.5

[sinclas]

Hi, Thanks for the update. The install 2.8.2 but had to reset watchman and do a clean build. Now its working. Awesome. thanks.

…

On May 14, 2021, at 8:22 AM, Reagan Elm ***@***.***> wrote: The fix was released in 2.8.2 <https://github.com/auth0/react-native-auth0/releases/tag/v2.8.2>. Are you still seeing issues with the latest version? Its working for our team with 14.5 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#369 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJ7G5DZES5XXZV3NMWZHQDTNUP25ANCNFSM43YGO3TQ>.

[fzaffarana]

I have the same problem using version 1.6.0 (react-native-auth0).

My problem is that I can't update it because the project is using version 0.59.9 of rn. (version 1.6.0 is a fixed version for 0.59.9 based on the documentation)

is there any fix for this version (1.6.0)?