Bind all methods of Auth0VueClient to this #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/plugin.ts
Outdated
Comment on lines
52
to
67
| const plugin = this; | ||
|
|
||
| // Vue Plugins can have issues when passing around the instance to `provide` | ||
| // Therefor we need to bind all methods correctly to `this`. | ||
| this.loginWithRedirect = this.loginWithRedirect.bind(plugin); | ||
| this.loginWithPopup = this.loginWithPopup.bind(plugin); | ||
| this.logout = this.logout.bind(plugin); | ||
| this.getAccessTokenSilently = this.getAccessTokenSilently.bind(plugin); | ||
| this.getAccessTokenWithPopup = this.getAccessTokenWithPopup.bind(plugin); | ||
| this.checkSession = this.checkSession.bind(plugin); | ||
| this.handleRedirectCallback = this.handleRedirectCallback.bind(plugin); | ||
| this.buildAuthorizeUrl = this.buildAuthorizeUrl.bind(plugin); | ||
| this.buildLogoutUrl = this.buildLogoutUrl.bind(plugin); | ||
| this.__checkSession = this.__checkSession.bind(plugin); | ||
| this.__refreshState = this.__refreshState.bind(plugin); | ||
| this.__proxy = this.__proxy.bind(plugin); |
There was a problem hiding this comment.
Just a question, is there a dynamic way we can do this (e.g. find all functions that are direct members of this and bind it)? I can just see this being missed later; if we add new methods later we're likely to forget to add it to this list and run into issues when someone tries to use it.
There was a problem hiding this comment.
Updated the PR to do it more dynamic.
frederikprijck
commented
Apr 27, 2022
| @@ -148,7 +153,7 @@ export class Auth0Plugin implements Auth0VueClient { | |||
| } | |||
| } | |||
|
|
|||
| async __refreshState() { | |||
| private async __refreshState() { | |||
There was a problem hiding this comment.
Made this private as it shouldnt be public
stevehobbsdev
approved these changes
Apr 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue when setting
thisas the value when calling Vue'sprovide. To solve it, we should bind all methods usingthis.Vuex appeared to have solved it in the same way.