Add function to get recorded keys from proof recorder instance #8
Conversation
There was a problem hiding this comment.
First of all, excellent PR description!
I am not sure if this can be upstreamed
Have you tried to open a conversation upstream? Better yet, since this is a trivial change just submit a PR there and you might get the first approval within the first hour.
Overall I'm fine with this change, but since it is a bit painful to upgrade Substrate, I think it'd be valuable to pull more stuff in, at least paritytech#2155, but ideally full upgrade if time allows.
Make sense. I will open a PR in upstream. Will keep this PR open till we receive any feedback from upstream folks. |
|
PR is opened here: paritytech#2561 |
ParthDesai
force-pushed
the
add-fn-to-get-recorded-keys
branch
from
8466c62
to
c760302
Compare
Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context,
including:
This PR adds function to get recorded keys from proof recorder instance
This change is required to get the keys accessed by the trie backend during the runtime execution. The keys are already tracked by proof recorder, just aren't exposed publicly.
The changes are implemented by adding a public function in proof recorder that simply clones the
recorded_keysfield.@nazar-pc I am not sure if this can be upstreamed. Since this change is specific to our use case where we want to get the keys accessed instead of directly getting the proof (this functionality is already there.). Please correct me if I am wrong.