Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce custom Subspace genesis block builder #1613

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Introduce custom Subspace genesis block builder #1613

merged 1 commit into from
Jun 29, 2023

Conversation

liuchengxu
Copy link
Contributor

Pure refactoring, the downside of this PR is that it has more additions than deletions :P

Close #1033

Code contributor checklist:

nazar-pc
nazar-pc approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@nazar-pc nazar-pc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is quite a lot of boilerplate. While this is technically a better way to do it, I must say the hack we had before was quite elegant.

@nazar-pc nazar-pc merged commit 25ae19b into main Jun 29, 2023
9 checks passed
@nazar-pc nazar-pc deleted the custom-genesis-block-builder branch June 29, 2023 06:26
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Jun 29, 2023
@ParthDesai
import autonomys/subspace#1607 autonomys/subspace#1604 autonomys/subs…
d1e95f3 
…pace#1613 autonomys/subspace#1615 autonomys/subspace#1621
jfrank-summit pushed a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Jun 30, 2023
@ParthDesai @jfrank-summit
import autonomys/subspace#1607 autonomys/subspace#1604 autonomys/subs…
27b85c6 
…pace#1613 autonomys/subspace#1615 autonomys/subspace#1621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc approved these changes

@vedhavyas vedhavyas vedhavyas approved these changes

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subspace custom genesis block
3 participants
@liuchengxu @nazar-pc @vedhavyas