Set up EVM domain testing infra and enable domain tests #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
vedhavyas
previously approved these changes
Jun 29, 2023
|
|
||
| /// Return key pair. | ||
| pub fn pair(self) -> Pair { | ||
| ecdsa::Pair::from_string(self.to_seed().as_str(), None).unwrap() |
There was a problem hiding this comment.
Not a blocker but this will not work all kinds of domains. So we would need to re think this at a later time
There was a problem hiding this comment.
Right, the domain test service is not generic over the signing scheme, will leave a TODO for now.
liuchengxu
previously approved these changes
Jun 29, 2023
Signed-off-by: linning <linningde25@gmail.com>
liuchengxu
approved these changes
Jun 29, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 29, 2023
jfrank-summit
pushed a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The domain testing infra is temporarily removed in #1575, this PR brings it back and replaces the system domain with the EVM domain as the testing domain.
But the fraud tests are still disabled due to they are broken and will change much in the future.
Code contributor checklist: