This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Pause Substrate sync #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
approved these changes
Jun 27, 2023
|
|
||
| return | ||
| }, | ||
| PollBlockAnnounceValidation::ImportHeader { announce, is_best, who } => { |
There was a problem hiding this comment.
I wonder, why did you remove this option?
There was a problem hiding this comment.
It is a part of paritytech#14465 and it was no longer used after SyncMode::Light enum variant was gone, I just pulled the strings and removed all unused code after that.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit was sent upstream here: paritytech#14465
The second commit makes
sync_modeupdatable and third introducesSyncMode::Pausedthat temporarily makes node not request blocks from other nodes, we'll use that to pause regular Substrate sync when doing sync from DSN (otherwise it results in a decreased reputation of connected peers and a lot of unnecessary reconnections/disconnections).I'll try to upstream the other two commits if/when the first one lands upstream.
I have tested this locally with Subspace node, seems to behave as expected.
Needed for autonomys/subspace#1514