This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Unify SyncMode data structures under one
#14465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
unify-sync-mode
branch
from
025aa33
to
c4886c4
Compare
|
Initial change was a bit incorrect, after which I noticed even more things can be removed with light sync mode gone |
nazar-pc
force-pushed
the
unify-sync-mode
branch
from
c4886c4
to
063d288
Compare
altonen
approved these changes
Jun 29, 2023
altonen
added
A0-please_review
dmitry-markin
approved these changes
Jun 29, 2023
bkchr
approved these changes
Jun 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two of the same, but slightly different enums. For some other changes I'm planning to do it is helpful if they are the same.
Lightsync mode was removed as it is not used for some time.SyncMode::FastisSyncMode::LightStatenow the way it was in one of the data structures (and is a better name IMHO).When creating this PR I noticed there is a third
SyncModeinsc-cli, I didn't touch it.