feat(euclidean_cluster): use point_cloud_msg_wrapper

[esteve]

Description

This PR replaces the standard point cloud iterators from the sensor_msgs package with Point Cloud Message Wrapper

Related links

#1199

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Base: 10.40% // Head: 10.40% // No change to project coverage 👍

Coverage data is based on head (a07358a) compared to base (a07358a).
Patch has no changes to coverable lines.

❗ Current head a07358a differs from pull request most recent head 134c396. Consider uploading reports for the commit 134c396 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   10.40%   10.40%           
=======================================
  Files        1169     1169           
  Lines       83489    83489           
  Branches    19549    19549           
=======================================
  Hits         8685     8685           
  Misses      65301    65301           
  Partials     9503     9503           

Flag	Coverage Δ
total	10.38% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kenji-miyake]

@yukkysaito @aohsato @miursh Could you review this? 🙏

[esteve]

@kenji-miyake sorry, this is still not ready, there are some more places in euclidean_cluster where I need to migrate to point_cloud_msg_wrapper

[kenji-miyake]

Okay, when you are ready, please let them know again!

[esteve]

@kenji-miyake @yukkysaito @aohsato @miursh this is now read for review, but I have a question about how to store RGB values (see #1200 (comment))

[yukkysaito]

Note:
Waiting for documents for point types.
#1200 (comment)

[esteve]

@yukkysaito @mitsudome-r @kaancolak @xmfcx I've rebased this PR and fixed the conflicts, is it still waiting on #1200 (comment) ?

[mitsudome-r]

For the distortion correction, we reverted migration to point_cloud_msg_wrapper.
Should we wait for this to be fixed?

[stale]

This pull request has been automatically marked as stale because it has not had recent activity.

[miursh]

@mitsudome-r @esteve
Do we still have the motivation to use this point_cloud_msg_wrapper?
If not, would it be acceptable to close this PR for now?

[miursh]

We are closing this issue for now since there has been no response for a month. Please feel free to reopen it if the issue still persists.

[esteve]

@miursh thanks