ci(build-and-test): add no-cuda build #1307

kenji-miyake · 2022-07-11T10:05:22Z

Description

To prevent errors like #1304.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

kenji-miyake · 2022-07-11T10:05:47Z

.github/sync-files.yaml

    - source: .github/workflows/check-build-depends.yaml
      pre-commands: |
        sd "container: ros:(\w+)" "container: ghcr.io/autowarefoundation/autoware-universe:\$1-latest-cuda" {source}
        sd -f ms '(rosdistro: humble.*?build-depends-repos): build_depends.repos' '$1: build_depends.humble.repos' {source}
-    - source: .github/workflows/clang-tidy-pr-comments.yaml


This setting was unnecessary.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

kenji-miyake · 2022-07-11T10:12:29Z

CI in #1308:
https://github.com/autowarefoundation/autoware.universe/actions/runs/2649143388

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

kenji-miyake · 2022-07-11T11:17:37Z

.github/sync-files.yaml

-    - source: .github/workflows/clang-tidy-pr-comments.yaml
-      pre-commands: |
-        sd "container: ros:(\w+)" "container: ghcr.io/autowarefoundation/autoware-universe:\$1-latest-cuda" {source}
+        sd "container: ros:(\w+)" "container: ghcr.io/autowarefoundation/autoware-universe:\$1-latest" {source}


This was also unnecessary.

mitsudome-r

LGTM

mitsudome-r

LGTM

* Porting remote cmd selector (autowarefoundation#1286) * Feature/add remote cmd selector (autowarefoundation#1179) * Add in/out args of remote_cmd_converter.launch Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change remote input topic of vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add msgs for remote_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add remote_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename remote_cmd_selector to external_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove VehicleCommand support in autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Support external_cmd_source in autoware_joy_controller.launch (autowarefoundation#1194) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix porting miss Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix missing function * modify xml format * fix include guard * add callback group * modify remap name * Revert "modify remap name" This reverts commit 169cc8d28442825b1d61b0439b9892c913304527. * change topic name * use rclcpp_component * Remove autoware_debug_msgs from autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change default mode of autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix ament (autowarefoundation#1307) * Ros2/create/external commands (autowarefoundation#1299) * add remote message * add remote commands * fix topic * remove unnecessary topic * remove unused topic * add external cmd instead * ToExternalComd * fix topic in joy con * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * suppress warnings for control packages (autowarefoundation#1892) * add Werror * add maybe unused * Add autoware api (autowarefoundation#1979) * Move launch file of external_cmd_selector (autowarefoundation#2017) * Move launch file of external_cmd_selector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add copyright Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Use DeclareLaunchArgument Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix external command api name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Move common parameters Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030) * Use EmergencyState instead of deprecated EmergencyMode Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use stamped type Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Improve diagnostic tree for future extensions (autowarefoundation#2153) * change resource monitoring group * implement diagnostic tree proposal * rename v2x param file * add v2x to launch * add dummy analyzer to avoid format error * modify external control * rename vehicle_ecu_errors * fixup * remove num_items * fix error * add heartbeat to external command selector * Restore sensing/node_alive_monitoring * Update system/autoware_error_monitor/config/diagnostic_aggregator/sensing.param.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * add sensor_kit arg for diagnostic_agg * change sensor_kit's default value * add _ prefix to hide parameter file * delete dummy parameter * change to use update_functions * add extra_agg_config_file_vehicle * change initializer * remove line * Update system/autoware_error_monitor/config/diagnostic_aggregator/system.param.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * change hearbeat diag * add clock group * update sensing diag * Remove discard and v2x Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix heartbeat name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add remote_external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename remote_control to external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename command_gate to control_command_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Simplify resource monitoring Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove sensing from autoware_error_monitor.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove trajectory_deviation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove vehicle specific settings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add blank lines Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore matching_score error Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove debug_data_logger Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add trajectory_validation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Specify children for performance_monitoring Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Comment out route_validation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Revert "Remove trajectory_deviation" This reverts commit 199132f1a6c7083440f0ef9a956b0663d45f4531. * Remove control_command_topic_status Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Disable some diagnostics for planning simulator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add TODO comment Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Enable /autoware/vehicle/node_alive_monitoring in planning simulator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix missing dependency of external_cmd_selector (autowarefoundation#2324) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port part of external_cmd_selector (autowarefoundation#497) * port part of external_cmd_selector Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * add convert function Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * port signal Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * Update control/external_cmd_selector/include/external_cmd_selector/external_cmd_selector_node.hpp Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Fix publisher in external_cmd_selector (autowarefoundation#676) Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* ci(build-and-test): add no-cuda build Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

…ain-sync chore: sync beta branch beta/v0.28.0 with tier4/main

…et filtering (autowarefoundation#1307) * chore(package.xml): bump version to 0.38.0 (autowarefoundation#1226) * add changelog Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * unify package.xml version to 0.37.0 Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * 0.38.0 * fix organization Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * youtalk username Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update changelog Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * 0.39.0 * Update autoware_launch/CHANGELOG.rst Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * change username Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chore(package.xml): bump version to 0.39.0 (autowarefoundation#1248) Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> Signed-off-by: Go Sakayori <gsakayori@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com> Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: xtk8532704 <1041084556@qq.com> Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Co-authored-by: Yuki TAKAGI <141538661+yuki-takagi-66@users.noreply.github.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Taekjin LEE <technolojin@gmail.com> Co-authored-by: SakodaShintaro <rgbygscrsedppbwg@gmail.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: iwatake <take.iwiw2222@gmail.com> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: xtk8532704 <1041084556@qq.com> * feat: add height filter option for lanelet filter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: add description in parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> Signed-off-by: Go Sakayori <gsakayori@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com> Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: xtk8532704 <1041084556@qq.com> Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Yuki TAKAGI <141538661+yuki-takagi-66@users.noreply.github.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Taekjin LEE <technolojin@gmail.com> Co-authored-by: SakodaShintaro <rgbygscrsedppbwg@gmail.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: iwatake <take.iwiw2222@gmail.com> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Co-authored-by: xtk8532704 <1041084556@qq.com> Co-authored-by: Junya Sasaki <j2sasaki1990@gmail.com> Co-authored-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

ci(build-and-test): add no-cuda build

c4b781c

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

kenji-miyake commented Jul 11, 2022

View reviewed changes

fix

a9bbfc5

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Kenji Miyake added 4 commits July 11, 2022 19:53

fix

846fdce

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

fix

7672023

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

fix

b4f6e60

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

fix

e74e711

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

kenji-miyake marked this pull request as ready for review July 11, 2022 11:13

kenji-miyake mentioned this pull request Jul 11, 2022

chore: sync files #1308

Merged

kenji-miyake requested a review from mitsudome-r July 11, 2022 11:13

kenji-miyake commented Jul 11, 2022

View reviewed changes

mitsudome-r approved these changes Jul 11, 2022

View reviewed changes

mitsudome-r merged commit b11a689 into main Jul 11, 2022

mitsudome-r deleted the add-no-cuda-ci branch July 11, 2022 12:14

tier4-autoware-public-bot bot mentioned this pull request Jul 11, 2022

chore: sync upstream tier4/autoware.universe#87

Merged

kenji-miyake mentioned this pull request Aug 23, 2022

ci(build-and-test-differential): disable no-cuda test #1669

Merged

4 tasks

xmfcx mentioned this pull request Oct 2, 2023

ci(build-and-test-differential): remove sync for the build-and-test-differential workflows #5200

Merged

4 tasks

saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Jul 2, 2024

Merge pull request autowarefoundation#1307 from tier4/beta-to-tier4-m…

a732236

…ain-sync chore: sync beta branch beta/v0.28.0 with tier4/main

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(build-and-test): add no-cuda build #1307

ci(build-and-test): add no-cuda build #1307

kenji-miyake commented Jul 11, 2022 •

edited

Loading

kenji-miyake Jul 11, 2022

kenji-miyake commented Jul 11, 2022 •

edited

Loading

kenji-miyake Jul 11, 2022

mitsudome-r left a comment

mitsudome-r left a comment

ci(build-and-test): add no-cuda build #1307

ci(build-and-test): add no-cuda build #1307

Conversation

kenji-miyake commented Jul 11, 2022 • edited Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

kenji-miyake Jul 11, 2022

Choose a reason for hiding this comment

kenji-miyake commented Jul 11, 2022 • edited Loading

kenji-miyake Jul 11, 2022

Choose a reason for hiding this comment

mitsudome-r left a comment

Choose a reason for hiding this comment

mitsudome-r left a comment

Choose a reason for hiding this comment

kenji-miyake commented Jul 11, 2022 •

edited

Loading

kenji-miyake commented Jul 11, 2022 •

edited

Loading