Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_control_rviz_plugin): apply clang-tidy #1597

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 16, 2022

Description

  • apply NOLINT for readability-redundant-access-specifiers due to Qt
  • fix below
    • readability-identifier-naming
    • modernize-use-auto
    • clang-diagnostic-unused-lambda-capture
    • cppcoreguidelines-pro-type-member-init

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #1597 (6710743) into main (98c46eb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
- Coverage   10.78%   10.77%   -0.01%     
==========================================
  Files        1111     1111              
  Lines       78525    78520       -5     
  Branches    18551    18551              
==========================================
- Hits         8465     8460       -5     
+ Misses      61339    61338       -1     
- Partials     8721     8722       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.75% <0.00%> (-0.01%) ⬇️ Carriedforward from aca79d5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ontrol_rviz_plugin/src/tools/manual_controller.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
perception/tensorrt_yolo/lib/src/trt_yolo.cpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
...lidar_centerpoint/lib/network/tensorrt_wrapper.cpp 0.00% <0.00%> (ø)
...idar_apollo_instance_segmentation/src/detector.cpp 0.00% <0.00%> (ø)
...raffic_light_ssd_fine_detector/lib/src/trt_ssd.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta requested a review from taikitanaka3 August 17, 2022 00:14
@h-ohta h-ohta marked this pull request as ready for review August 17, 2022 00:53
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta
Copy link
Contributor Author

h-ohta commented Aug 17, 2022

@taikitanaka3 I revert readability-identifier-naming.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta enabled auto-merge (squash) August 17, 2022 02:44
@h-ohta h-ohta merged commit 41e2c99 into autowarefoundation:main Aug 17, 2022
@h-ohta h-ohta deleted the refactor/tier4_control_rviz_plugin branch August 18, 2022 10:07
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* refactor(tier4_control_rviz_plugin): apply clang-tidy

* revert: readability-identifier-naming

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* refactor(tier4_control_rviz_plugin): apply clang-tidy

* revert: readability-identifier-naming

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* refactor(tier4_control_rviz_plugin): apply clang-tidy

* revert: readability-identifier-naming

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…tion#1597)

* refactor(tier4_control_rviz_plugin): apply clang-tidy

* revert: readability-identifier-naming

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* refactor(tier4_control_rviz_plugin): apply clang-tidy

* revert: readability-identifier-naming

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants