Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils): add new resmaple path #2015

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Oct 4, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

I created a function to resamplePath (type is Path) with the same interval

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 force-pushed the feat/new-resample-path branch 2 times, most recently from 8c4b1a8 to 51247ca Compare October 4, 2022 09:37
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/new-resample-path branch from 51247ca to 6cc2b63 Compare October 4, 2022 09:38
@takayuki5168 takayuki5168 marked this pull request as ready for review October 4, 2022 09:39
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/new-resample-path branch from ea7b722 to 67e81ca Compare October 4, 2022 09:40
@takayuki5168
Copy link
Contributor Author

@purewater0901 Could you review this PR.
Most of the code is copied from the other part in this file.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 10.34% // Head: 10.48% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (67e81ca) compared to base (8dae2a2).
Patch coverage: 34.68% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
+ Coverage   10.34%   10.48%   +0.14%     
==========================================
  Files        1162     1162              
  Lines       82730    83972    +1242     
  Branches    19268    20180     +912     
==========================================
+ Hits         8560     8808     +248     
- Misses      65043    65692     +649     
- Partials     9127     9472     +345     
Flag Coverage Δ *Carryforward flag
differential 11.15% <27.38%> (?)
total 10.32% <25.30%> (ø) Carriedforward from 8dae2a2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/motion_utils/src/resample/resample.cpp 36.42% <27.27%> (+5.45%) ⬆️
...n/motion_utils/test/src/resample/test_resample.cpp 29.18% <35.50%> (+3.24%) ⬆️
planning/behavior_path_planner/src/utilities.cpp 2.85% <0.00%> (-0.27%) ⬇️
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
...or_path_planner/src/scene_module/pull_out/util.cpp 0.00% <0.00%> (ø)
...r/src/freespace_planner/freespace_planner_node.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit a6cf5fc into autowarefoundation:main Oct 5, 2022
@takayuki5168 takayuki5168 deleted the feat/new-resample-path branch October 5, 2022 03:00
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
* feat(motion_utils): add new resmaple path

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants