Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static centerline optimizer): new package #2013

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Oct 4, 2022

Description

This PR depends on

TODO

  • Sometimes path planning failed.
    • Actually, the path planning function is not so much tested. At least, simple case (path planning with a few left, right turn) has been tested.
  • Elastic band is disabled
  • successive path optimization

Example command to plan path with kashiwanoha map
ros2 launch static_centerline_optimizer static_centerline_optimizer.launch.xml run_background:=false lanelet2_input_file_path:="/home/takayukimurooka/AutonomousDrivingScenarios/map/kashiwanoha/lanelet2_map.osm" start_lanelet_id:=125 end_lanelet_id:=132 vehicle_model:=lexus

Related links

#1942

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 changed the title Feat/static centerline optimizer feat(static centerline optimizer): new package Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 11.13% // Head: 11.06% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (311a598) compared to base (c581441).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2013      +/-   ##
==========================================
- Coverage   11.13%   11.06%   -0.07%     
==========================================
  Files        1204     1208       +4     
  Lines       86297    86837     +540     
  Branches    20827    20827              
==========================================
  Hits         9606     9606              
- Misses      66533    67073     +540     
  Partials    10158    10158              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.10% <ø> (ø) Carriedforward from fb5f422

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ne_optimizer/src/collision_free_optimizer_node.cpp 0.00% <0.00%> (ø)
planning/static_centerline_optimizer/src/main.cpp 0.00% <0.00%> (ø)
...optimizer/src/static_centerline_optimizer_node.cpp 0.00% <0.00%> (ø)
planning/static_centerline_optimizer/src/utils.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 added the type:documentation Creating or refining documentation. (auto-assigned) label Oct 4, 2022
@takayuki5168 takayuki5168 force-pushed the feat/static-centerline-optimizer branch 3 times, most recently from f855bc1 to 0c287cd Compare October 17, 2022 11:43
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/static-centerline-optimizer branch from 0c287cd to da9290c Compare November 9, 2022 17:01
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/static-centerline-optimizer branch from 602ec8a to 8fef943 Compare November 10, 2022 01:52
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review November 10, 2022 04:02
@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Nov 10, 2022

mission_planner's change in this PR is the same as #2259
After #2259 is merged, remove mission_planner's change from this PR, and merge this PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@TakaHoribe
Copy link
Contributor

It worked perfectly. Please let me know after CI issue is fixed.
image

@takayuki5168 takayuki5168 force-pushed the feat/static-centerline-optimizer branch from 2a1f2d2 to 6e6cbe1 Compare November 12, 2022 15:01
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) document labels Nov 14, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Nov 14, 2022

@TakaHoribe
Thanks to the massive help from @kenji-miyake -san, all the required CI passed finally.
Give me LGTM!

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@takayuki5168 takayuki5168 merged commit 3d714ac into autowarefoundation:main Nov 15, 2022
@takayuki5168 takayuki5168 deleted the feat/static-centerline-optimizer branch November 15, 2022 10:03
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
* feat(mission_planner): add another initialization function

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(static_centerline_optimizer): add a new package

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix spell

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* revert mission_planner's change

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix png path

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove unnecessary cerr

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix colcon test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update cmake version

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* tmp fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix CI error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix CI error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
* feat(mission_planner): add another initialization function

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(static_centerline_optimizer): add a new package

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix spell

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* revert mission_planner's change

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix png path

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove unnecessary cerr

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix colcon test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update cmake version

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* tmp fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix CI error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix CI error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
* feat(mission_planner): add another initialization function

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(static_centerline_optimizer): add a new package

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix spell

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* revert mission_planner's change

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix png path

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove unnecessary cerr

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix colcon test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update cmake version

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* tmp fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix CI error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix CI error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants