-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mission_planner): add another initialization function #2259
feat(mission_planner): add another initialization function #2259
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportBase: 11.14% // Head: 11.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
==========================================
- Coverage 11.14% 11.13% -0.01%
==========================================
Files 1203 1203
Lines 86268 86312 +44
Branches 20829 20829
==========================================
Hits 9615 9615
- Misses 66490 66534 +44
Partials 10163 10163
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
planning/mission_planner/include/mission_planner/mission_planner_plugin.hpp
Outdated
Show resolved
Hide resolved
planning/mission_planner/include/mission_planner/mission_planner_plugin.hpp
Outdated
Show resolved
Hide resolved
@isamu-takagi If you can, I wanna get your approval today (before you will have days off). |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oundation#2259) * feat(mission_planner): add another initialization function Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/mission_planner/include/mission_planner/mission_planner_plugin.hpp * apply clang-format Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove unnecessary namespaces Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…oundation#2259) * feat(mission_planner): add another initialization function Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/mission_planner/include/mission_planner/mission_planner_plugin.hpp * apply clang-format Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove unnecessary namespaces Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
To realize static center line optimizer as follows, mission_planner has to be called statically.
#1942
Therefore, I created this PR to ask mission_planner to plan route statically without runtime callback.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.