Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freespace_planner): write algorithm options in param file #2100

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Oct 18, 2022

Description

Add a comment as in the title

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe force-pushed the feat/add-comment-freespace-planning branch from 0ab5d41 to 3fdd6a6 Compare October 18, 2022 13:06
@TakaHoribe TakaHoribe requested a review from tkimura4 October 18, 2022 13:07
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 10.37% // Head: 10.35% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3fdd6a6) compared to base (8fc7be4).
Patch coverage: 42.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2100      +/-   ##
==========================================
- Coverage   10.37%   10.35%   -0.02%     
==========================================
  Files        1175     1175              
  Lines       84044    84157     +113     
  Branches    19591    19591              
==========================================
  Hits         8717     8717              
- Misses      65791    65904     +113     
  Partials     9536     9536              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.35% <46.31%> (ø) Carriedforward from 8fc7be4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/freespace_planner/freespace_planner_node.hpp 0.00% <ø> (ø)
...r/src/freespace_planner/freespace_planner_node.cpp 0.00% <0.00%> (ø)
...ude/freespace_planning_algorithms/astar_search.hpp 87.50% <ø> (ø)
...eespace_planning_algorithms/abstract_algorithm.hpp 44.44% <50.00%> (ø)
...freespace_planning_algorithms/src/astar_search.cpp 71.68% <50.00%> (ø)
.../freespace_planning_algorithms/src/reeds_shepp.cpp 55.51% <50.00%> (ø)
...ms/test/src/test_freespace_planning_algorithms.cpp 63.49% <58.33%> (ø)
...ace_planning_algorithms/src/abstract_algorithm.cpp 78.16% <70.00%> (ø)
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit a0acc44 into autowarefoundation:main Oct 31, 2022
@tkimura4 tkimura4 deleted the feat/add-comment-freespace-planning branch October 31, 2022 05:26
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…arefoundation#2100)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants