Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pointcloud_preprocessor): suppress CGAL warning #2156

Merged

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Oct 26, 2022

Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp

Description

Added CGAL_DATA_DIR variable to suppress warning from CGAL.

Without this variable, CGAL will show following warning because of CGAL::data_file_path function.
CGAL::data_file_path is not used in Autoware, so I added temporary value of ".".

Starting >>> pointcloud_preprocessor
[Processing: pointcloud_preprocessor]                             
[Processing: pointcloud_preprocessor]                                     
[Processing: pointcloud_preprocessor]                                       
--- stderr: pointcloud_preprocessor                                          
CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/CGAL/CGALConfig.cmake:92 (message):
  CGAL_DATA_DIR cannot be deduced, set the variable CGAL_DATA_DIR to set the
  default value of CGAL::data_file_path()
Call Stack (most recent call first):
  CMakeLists.txt:15 (find_package)

---
Finished <<< pointcloud_preprocessor [1min 41s]

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 10.78% // Head: 10.78% // No change to project coverage 👍

Coverage data is based on head (26f41d6) compared to base (897794a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2156   +/-   ##
=======================================
  Coverage   10.78%   10.78%           
=======================================
  Files        1186     1186           
  Lines       84842    84842           
  Branches    19899    19899           
=======================================
  Hits         9149     9149           
  Misses      66002    66002           
  Partials     9691     9691           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.76% <ø> (ø) Carriedforward from 897794a

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TomohitoAndo TomohitoAndo marked this pull request as ready for review October 27, 2022 01:12
@TomohitoAndo TomohitoAndo changed the title chore: suppress cgal warning chore: suppress CGAL warning Oct 27, 2022
@TomohitoAndo TomohitoAndo changed the title chore: suppress CGAL warning chore(pointcloud_preprocessor): suppress CGAL warning Oct 27, 2022
@TomohitoAndo TomohitoAndo merged commit 066c932 into autowarefoundation:main Oct 27, 2022
@TomohitoAndo TomohitoAndo deleted the suppress-cgal-warning branch October 27, 2022 23:17
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…tion#2156)

chore: suppress CGAL warning

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants