-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(planning_test_utils): fix build error #3410
fix(planning_test_utils): fix build error #3410
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3410 +/- ##
=======================================
Coverage 12.22% 12.23%
=======================================
Files 1380 1380
Lines 96890 96830 -60
Branches 28017 27984 -33
=======================================
Hits 11847 11847
+ Misses 72487 72425 -62
- Partials 12556 12558 +2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
* add planning_interface_test_manager class Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add counter function Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add interface test for motion_velocity_smoother Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add param in default_motion_velocity_smoother,param.yaml Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * successfully launch target node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * successfully build the test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add test for test_motion_velocity_smoother Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add abnormal trajectory test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary part Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * style(pre-commit): autofix * run pre-commit Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add declaration Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor callback functions for standardization Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refacotoring Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactored Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor functions into a single template function Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * relete unnecessary definition Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Revert "delete unnecessary definition" This reverts commit 6cd13f8. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary definition Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary definition Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete module dependent part Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary arg Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * apply motion_velocity_smoother change Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add interface test for obstacle stop planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * run pre-commit Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add test fot obstacle_cruise_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add test fot planning_vaildator Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add interface test for freespace_planner_node Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add interface test for obstacle_stop_planner with slow down Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add part of interface test for freespace Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change package name Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * apply change of package name Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp commit for debug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add planning interface test manager for scenario selector Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update parameter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp for behavior_path_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add param file Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add test free space planner module Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update map Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add test for behavior path planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pass freespace test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pass freespace test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update map Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update map detection area Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add no stopping area Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * for print debug Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update param Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add param file Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor(behavior_path_planner): remove unnecessary functions (#3271) * refactor(behavior_path_planner): remove unnecessary functions Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com> * Revert "temp" This reverts commit b82805e. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * suppress build error (-Werror=pedantic) Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add interface test for behavior_velocity_planner * build success Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add param Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pass test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * pass test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * build success Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update param Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete param file Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Resolve differences outside of parameter files Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update test manager Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update test manager Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * upload cloud map Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix typo Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor utils Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor utils Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor test_manager Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test for obstacle cruise planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test for obstacle_stop_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * revert parameter change Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add obstacle_avoidance_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Revert "add obstacle_avoidance_planner" This reverts commit efb5d50. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add planning_validator Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add rosidl_default_generators in CMake Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Revert "add rosidl_default_generators in CMake" This reverts commit 7f87b0a. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete unnecessary files Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor(behavior_velocity_planner::intersection): organize param intersection (#3409) * reorganize intersection param for readability Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * reorganized PlannerParam Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * refactor(lane_following): remove duplicated reference path generation process (#3398) * feat(utils): add new function Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(behavior_path_planner): use utils function Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(planning_test_utils): fix build error (#3410) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(pointcloud_preprocessor): fix broken logic (#3122) `if (a && b, c)` is the same as `if (c)` not `if (a && b && c)` !! Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com> * refactor(crop_box_filter): remove always true condition (#3245) * refactor(crop_box_filter): remove always true condition tf_input_frame_ can't be empty in crop box filter. Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> * style(pre-commit): autofix --------- Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(pointcloud_preprocessor): add data layout check utils (#3306) * feat(pointcloud_preprocessor): add data layout check utils When input cloud data layout is compatible filters can copy data faster. Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> * style(pre-commit): autofix * add "name" field check cleaning Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> --------- Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * update cmake minimum version Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com> Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Vincent Richard <vincent.francois.richard@gmail.com>
Description
fix build error
Tests performed
Build pass in my pc.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.