feat: use vehicle_stop_checker for judging vehicle stop vehicle_cmd_gate #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:control
|
If we use stop_duration common to ADAPI, I'll close this PR since we can use |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4060 +/- ##
==========================================
- Coverage 14.38% 14.38% -0.01%
==========================================
Files 1563 1563
Lines 107446 107448 +2
Branches 31117 31118 +1
==========================================
Hits 15454 15454
- Misses 75194 75196 +2
Partials 16798 16798
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Before
After |
7 tasks
tkimura4
force-pushed
the
feat/use_vehicle_stop_checker_in_vehicle_cmd_gate
branch
from
d05ebb6 to
c2630f0
Compare
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4
force-pushed
the
feat/use_vehicle_stop_checker_in_vehicle_cmd_gate
branch
from
c2630f0 to
e5a7563
Compare
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Jul 3, 2023
…ate (autowarefoundation#4060) * feat: use vehicle_stop_checker for judging vehicle stop vehicle_cmd_gate Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * remove unused include Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
4 tasks
mkuri
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 28, 2023
…ate (autowarefoundation#4060) * feat: use vehicle_stop_checker for judging vehicle stop vehicle_cmd_gate Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * remove unused include Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For vehicles that cannot acquire the vehicle speed in the low speed range, it may be incorrectly judged to be stopped
in the vehicle_cmd_gate node.
To prevent this, we use
vehicle_stop-checkerfor stop judgmentRelated links
autowarefoundation/autoware_launch#417
Tests performed
Psim Test OK.
Notes for reviewers
Interface changes
none
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.