Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vehicle_cmd_gate): reduce delay #637

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

maxime-clem
Copy link

@maxime-clem maxime-clem commented Jul 3, 2023

Description

Adds autowarefoundation#3385 and autowarefoundation#4060
Also needs https://github.com/tier4/autoware_launch.xx1/pull/534

Tests performed

Psim with pilot-auto.xx1.

Effects on system behavior

Reduced delays when restarting.

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

maxime-clem and others added 2 commits July 3, 2023 10:44
…ate (autowarefoundation#4060)

* feat: use vehicle_stop_checker for  judging vehicle stop vehicle_cmd_gate

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove unused include

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.8.1-odaiba1@c2080b0). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             beta/v0.8.1-odaiba1     #637   +/-   ##
======================================================
  Coverage                       ?   18.99%           
======================================================
  Files                          ?       16           
  Lines                          ?      858           
  Branches                       ?      401           
======================================================
  Hits                           ?      163           
  Misses                         ?      570           
  Partials                       ?      125           
Flag Coverage Δ
differential 18.99% <0.00%> (?)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit eddcb3d into tier4:beta/v0.8.1-odaiba1 Jul 3, 2023
@maxime-clem maxime-clem deleted the hotfix/reduce_delays branch July 3, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants