Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): extend lanelets for target filtering #4189

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 6, 2023

Description

🤖 Generated by Copilot at 5b94cbd

Extend ego lanelets for lane change planning in utils.cpp. This improves collision avoidance with traffic lights and crosswalks.

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 25.00% and no project coverage change.

Comparison is base (f8e74c5) 15.22% compared to head (5b94cbd) 15.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4189   +/-   ##
=======================================
  Coverage   15.22%   15.23%           
=======================================
  Files        1469     1469           
  Lines      101793   101800    +7     
  Branches    31405    31411    +6     
=======================================
+ Hits        15503    15505    +2     
+ Misses      69425    69424    -1     
- Partials    16865    16871    +6     
Flag Coverage Δ *Carryforward flag
differential 13.46% <25.00%> (?)
total 15.22% <ø> (-0.01%) ⬇️ Carriedforward from f8e74c5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/route_handler/src/route_handler.cpp 24.59% <ø> (-0.06%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 6.21% <25.00%> (+0.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have confirmed that unnecessary avoidances no longer occur.

before
image

after
Screenshot from 2023-07-06 18-53-48

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit db72d84 into autowarefoundation:main Jul 7, 2023
@satoshi-ota satoshi-ota deleted the fix/extend-lanelet branch July 7, 2023 03:09
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jul 7, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 7, 2023
…tion#4189) (#649)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants