Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cspell): add spell-check-partial #4320

Merged
merged 10 commits into from
Jul 18, 2023

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Jul 18, 2023

Description

This is the first step towards requiring a spellcheck CI path with pull request.
In this pull-request, add spell-check-partial workflow to be one of "required CIs" in the future.
As of now, this workflow is not "required" and ignore all paths of source code.

In the future, we will implement a gradual SpellCheck mandate by ignoring fewer paths.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 18, 2023
satoshi-ota and others added 3 commits July 18, 2023 20:05
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@HansRobo HansRobo force-pushed the feat/spell_check_partial branch from 93270ef to 44556c2 Compare July 18, 2023 11:06
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 18, 2023
HansRobo and others added 5 commits July 18, 2023 20:11
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…n#4312)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@HansRobo HansRobo force-pushed the feat/spell_check_partial branch from 1d9833a to 3973be1 Compare July 18, 2023 11:11
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jul 18, 2023
@github-actions github-actions bot removed component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jul 18, 2023
@HansRobo HansRobo requested a review from kminoda July 18, 2023 11:42
@HansRobo HansRobo marked this pull request as ready for review July 18, 2023 11:42
@HansRobo HansRobo enabled auto-merge (squash) July 18, 2023 11:43
@HansRobo HansRobo disabled auto-merge July 18, 2023 11:44
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansRobo HansRobo enabled auto-merge (squash) July 18, 2023 11:45
@HansRobo HansRobo merged commit 1d73b7a into autowarefoundation:main Jul 18, 2023
@HansRobo HansRobo deleted the feat/spell_check_partial branch July 18, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants