Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(map_projection_loader): unify the name of yaml file #4778

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Aug 28, 2023

Description

Unify name from projection_info to projector_info

Tests performed

Build and test passes

Effects on system behavior

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Aug 28, 2023
@kminoda kminoda marked this pull request as ready for review August 28, 2023 06:38
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
@kminoda kminoda changed the title fix(map_projection_loader): unify the name of yaml file style(map_projection_loader): unify the name of yaml file Aug 28, 2023
@kminoda kminoda removed the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: +0.04% 🎉

Comparison is base (e017725) 15.09% compared to head (051cdc4) 15.13%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4778      +/-   ##
==========================================
+ Coverage   15.09%   15.13%   +0.04%     
==========================================
  Files        1568     1568              
  Lines      108130   107962     -168     
  Branches    33173    33031     -142     
==========================================
+ Hits        16321    16345      +24     
+ Misses      74031    73937      -94     
+ Partials    17778    17680      -98     
Flag Coverage Δ *Carryforward flag
differential 37.28% <16.66%> (?)
total 15.13% <ø> (+0.04%) ⬆️ Carriedforward from 572cf8e

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 9.09% <ø> (+0.16%) ⬆️
...jection_loader/src/load_info_from_lanelet2_map.cpp 35.29% <0.00%> (-2.21%) ⬇️
...n_loader/test/test_load_info_from_lanelet2_map.cpp 42.42% <0.00%> (ø)
...ior_velocity_detection_area_module/src/manager.cpp 52.00% <ø> (+12.60%) ⬆️
...avior_velocity_intersection_module/src/manager.cpp 24.53% <ø> (+5.40%) ⬆️
...r_velocity_no_stopping_area_module/src/manager.cpp 34.61% <ø> (+8.14%) ⬆️
...ior_velocity_occlusion_spot_module/src/manager.cpp 2.50% <ø> (+1.05%) ⬆️
system/default_ad_api/src/vehicle.cpp 14.28% <ø> (+10.11%) ⬆️
...ap_projection_loader/src/map_projection_loader.cpp 26.66% <33.33%> (-1.91%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit 84107d0 into autowarefoundation:main Aug 28, 2023
@kminoda kminoda deleted the fix/map_projection_loader/projection_to_projector branch September 26, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants