feat(ndt_scan_matcher): remake diag #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamato-ando <Yamato ANDO>
github-actions
bot
added
the
component:localization
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
This was referenced Nov 9, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
I plan to resume work in December or January. |
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
sorry. I will put it on hold for a while. |
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
SakodaShintaro
added
the
run:build-and-test-differential
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
YamatoAndo
force-pushed
the
feat/remake_ndt_scan_matcher_diag
branch
from
07d4303 to
78b562c
Compare
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
4 tasks
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
* feat(ndt_scan_matcher): remake diag Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * add latest_ndt_aling_service_best_score Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * check nullptr Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * add validate_distance_from_initial_to_result Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * rename Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * update readme Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * [WIP] udpate Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * [WIP] udpate Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * add is_need_rebuild Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * add image Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * remove unused func Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * update image Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * remove unused include Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * move code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * move code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix FIX ME Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * remove unused func Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * add diag for trigger node service Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * move code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * delete unused code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * udpate Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * delete RCLCPP message Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * rename diag Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * rename func Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * remove Transition condition to OK Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix table Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * update readme Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix order Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * remove diag prefix Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix readme Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * rename diag Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * remove unused code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix double free Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * output to terminal Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> --------- Signed-off-by: yamato-ando <Yamato ANDO> Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: yamato-ando <Yamato ANDO> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remake the ndt_scan_matching's diagnostics.
before (2023/09/22)
after
outputs 6 messages
diagnostic for scan_matching_status
diagnostic for initial_pose_subscriber_status
diagnostic for regularization_pose_subscriber_status
diagnostic for trigger_node_service_status
diagnostic for ndt_align_service_status
diagnostic for map_update_status
If you want to know the conditions for transitioning to WARN/ERROR, please read the README.md.
Related links
ToDo
https://github.com/autowarefoundation/autoware.universe/tree/main/system/system_error_monitor/config
https://github.com/autowarefoundation/autoware_launch/tree/main/autoware_launch/config/system/system_error_monitor
https://github.com/autowarefoundation/autoware.universe/blob/main/simulator/fault_injection/config/fault_injection.param.yaml
https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/config/simulator/fault_injection.param.yaml
merge with
Tests performed
Lsim works
Notes for reviewers
N/A
Interface changes
message of
/diagnosticstopicEffects on system behavior
N/A
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.