feat(system diags): rename diag of ndt scan matcher #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
YamatoAndo
requested review from
ito-san,
isamu-takagi,
takayuki5168,
rej55,
satoshi-ota and
shmpwk
as code owners
10 tasks
|
@ito-san @isamu-takagi @takayuki5168 @rej55 @satoshi-ota @shmpwk |
ito-san
added
enhancement
|
@takayuki5168 @rej55 @satoshi-ota @shmpwk |
shmpwk
approved these changes
Apr 30, 2024
Ericpotato
added a commit
to tier4/autoware_launch
that referenced
this pull request
Nov 6, 2024
…utowarefoundation#973) * add hardware and sensing settings for diagnostic_graph_aggregator to replace system_error_monitoring Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * typo fixed Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * style(pre-commit): autofix * typo fixed Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * change config file name to autoware-main to sync Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * change diagnostic_graph_aggregator config file name to autoware-main Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * update autoware-psim setting Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * style(pre-commit): autofix * customize diagnostic_graph_aggregator config to target to autoware-main_xx1 Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * fix reference path of autoware-psim Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * use default config files name, remove files with _xx1 suffix Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp> Co-authored-by: Ericpotato <Ericpotato@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see autowarefoundation/autoware.universe#6889
Tests performed
see autowarefoundation/autoware.universe#6889
Effects on system behavior
see autowarefoundation/autoware.universe#6889
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.