Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(behavior_path_planner): update documentation of the dynamic drivablea area expansion #5661

Conversation

maxime-clem
Copy link
Contributor

Description

The dynamic drivable area expansion was recently changed to a curvature based implementation (#5294). This PR updates the documentation to fit the new implementation.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 24, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Nov 24, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a596) 15.32% compared to head (15c048f) 9.35%.
Report is 284 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5661       +/-   ##
==========================================
- Coverage   15.32%   9.35%    -5.98%     
==========================================
  Files        1721      87     -1634     
  Lines      118559   11154   -107405     
  Branches    37995    4584    -33411     
==========================================
- Hits        18169    1043    -17126     
+ Misses      79657    8274    -71383     
+ Partials    20733    1837    -18896     
Flag Coverage Δ
differential 9.35% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


##### 1 Calculate and smooth the path curvature

To avoid sudden changes of the expanded drivable area, we first try to reuse as much of the previous path and its calculated curvatures as possible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the expanded drivable area here refers to static or dynamic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it more clear that it was for the dynamic expansion (fd11526).

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem requested a review from soblin as a code owner November 29, 2023 12:10
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem merged commit cc1d483 into autowarefoundation:main Dec 26, 2023
23 of 24 checks passed
@maxime-clem maxime-clem deleted the docs/behavior_path_planner-curvature-based-drivablea_area_expansion branch December 26, 2023 00:24
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…ablea area expansion (autowarefoundation#5661)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…ablea area expansion (autowarefoundation#5661)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…ablea area expansion (autowarefoundation#5661)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ablea area expansion (autowarefoundation#5661)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants