-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(behavior_path_planner): update documentation of the dynamic drivablea area expansion #5661
Conversation
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5661 +/- ##
==========================================
- Coverage 15.32% 9.35% -5.98%
==========================================
Files 1721 87 -1634
Lines 118559 11154 -107405
Branches 37995 4584 -33411
==========================================
- Hits 18169 1043 -17126
+ Misses 79657 8274 -71383
+ Partials 20733 1837 -18896
☔ View full report in Codecov by Sentry. |
|
||
##### 1 Calculate and smooth the path curvature | ||
|
||
To avoid sudden changes of the expanded drivable area, we first try to reuse as much of the previous path and its calculated curvatures as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the expanded drivable area
here refers to static
or dynamic
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it more clear that it was for the dynamic expansion (fd11526).
planning/behavior_path_planner/docs/behavior_path_planner_drivable_area_design.md
Show resolved
Hide resolved
planning/behavior_path_planner/docs/behavior_path_planner_drivable_area_design.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ablea area expansion (autowarefoundation#5661) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ablea area expansion (autowarefoundation#5661) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ablea area expansion (autowarefoundation#5661) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ablea area expansion (autowarefoundation#5661) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Description
The dynamic drivable area expansion was recently changed to a curvature based implementation (#5294). This PR updates the documentation to fit the new implementation.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.