Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner, motion_velocity_smoother): supress unnecessary output #579

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Mar 24, 2022

Description

supress unnecessary output

  1. motion_velocity_smoother (L2)
    When the vehicle speed is low, apply function returns false and the following messages are output repeteadly.
    Fail to solve optimization.

if (std::fabs(input.front().longitudinal_velocity_mps) < 0.1) {
RCLCPP_DEBUG(logger_, "closest v_max < 0.1. assume vehicle stopped. return.");
return false;
}

RCLCPP_WARN(get_logger(), "Fail to solve optimization.");

However, in this case, the optimization has not failed and there is no need to output the avove message.
So, I fixed not to output the above message.

  1. turn_signal_decider in behavior_path_planner
    When convertToFrenetCoordinate3d returns false, the following message are output repeadly.
    failed to convert vehicle pose into frenet coordinate

(This function does the conversion of self-position to Frenet coordinates.)

However, if the self-position exceeds the goal even a little, the processing of this function will always fail.
So, I changed the output type of this function from ERROR to DEBUG.

if (!util::convertToFrenetCoordinate3d(path, current_pose.position, &vehicle_pose_frenet)) {
RCLCPP_ERROR_THROTTLE(
logger_, clock, 5000, "failed to convert vehicle pose into frenet coordinate");
return std::make_pair(turn_signal, distance);

Pre-review checklist for the PR author

PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has the write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from TakaHoribe March 24, 2022 09:11
@TakaHoribe TakaHoribe changed the title Fix/supress unnecessary output fix(behavior_path_planner, motion_velocity_smoother): supress unnecessary output Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #579 (88de003) into main (007487a) will decrease coverage by 10.91%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #579       +/-   ##
==========================================
- Coverage   10.91%   0.00%   -10.92%     
==========================================
  Files         706      44      -662     
  Lines       49835    6656    -43179     
  Branches     7116       0     -7116     
==========================================
- Hits         5438       0     -5438     
+ Misses      40016    6656    -33360     
+ Partials     4381       0     -4381     
Impacted Files Coverage Δ
.../behavior_path_planner/src/turn_signal_decider.cpp 0.00% <0.00%> (ø)
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp 0.00% <0.00%> (ø)
...nclude/lidar_apollo_instance_segmentation/util.hpp
map/lanelet2_extension/lib/road_marking.cpp
.../src/distortion_corrector/distortion_corrector.cpp
...n/include/traffic_light_roi_visualizer/nodelet.hpp
common/signal_processing/src/lowpass_filter_1d.cpp
common/autoware_auto_common/test/gtest_main.cpp
...nodes/costmap_generator/costmap_generator_node.cpp
..._planner/src/scene_module/detection_area/scene.cpp
... and 654 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007487a...88de003. Read the comment docs.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (This msg is not critical or not even error.)

@tkimura4 tkimura4 merged commit b1fc268 into autowarefoundation:main Mar 24, 2022
@tkimura4 tkimura4 deleted the fix/supress_unnecessary_output branch March 24, 2022 09:46
kosuke55 pushed a commit to kosuke55/autoware.universe that referenced this pull request Mar 24, 2022
* release v0.4.0

* Fix routing from crosswalk (autowarefoundation#767)

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 5eba353.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* port mission_planner to ROS2 (autowarefoundation#56)

* port mission_planner to ROS2

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix QoS for publishers

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Add geometry2 to repos (autowarefoundation#76)

* add geometry2 package temporarily until new release

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* trigger-ci

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add tf2 dependency to the packages that use tf2_geometry_msgs

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "Add geometry2 to repos (autowarefoundation#76)" (autowarefoundation#96)

* Revert "Add geometry2 to repos (autowarefoundation#76)"

This reverts commit 61defd0.

* Re-add tf2 dependencies

* Revert "Re-add tf2 dependencies"

This reverts commit e23b0c8b0826cf9518924d33349f9de34b4975df.

* Debug CI pipeline

* Revert "Debug CI pipeline"

This reverts commit 58f1eba550360d82c08230552abfb64b33b23e0f.

* Explicitly install known versions of the geometry packages

* No need to skip tf2 packages anymore

Co-authored-by: Esteve Fernandez <esteve@apache.org>

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* fixing trasient_local in ROS2 packages (autowarefoundation#160)

* Add linters to mission_planner (autowarefoundation#156)

* Added linters to mission_planner

* Removed duplicate dependencies

* Only add the cppcheck linter

* Added linters to CMake

* Ros2 v0.8.0 mission planner (autowarefoundation#278)

* add use_sim-time option (autowarefoundation#454)

* Fix rolling build errors (autowarefoundation#1225)

* Add missing include files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace rclcpp::Duration

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use reference for exceptions

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use from_seconds

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Make planning modules components (autowarefoundation#1263)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Fix compiler warnings (autowarefoundation#1837)

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-variable

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wformat-security

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Winvalid-constexpr

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wdelete-non-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wdelete-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Winconsistent-missing-override

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wrange-loop-construct

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix "invalid application of 'sizeof' to an incomplete type"

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wgnu-anonymous-struct and -Wnested-anon-types

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wno-deprecated-declarations in CUDA-related packages

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Docs/mission planner (autowarefoundation#1952)

* add doc

* update docs

* Invoke code formatter at pre-commit (autowarefoundation#1935)

* Run ament_uncrustify at pre-commit

* Reformat existing files
* Fix copyright and cpplint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* update mission planner doc (autowarefoundation#2044)

* update mission planner doc

* fix typo

* Update planning/mission_planning/mission_planner/mission_planner-design.md

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* add pull over/out module (autowarefoundation#2147)

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* rename to README.md (autowarefoundation#550)

* rename to README.md

* dealt with new auto_msgs format

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>

* port mission planner (autowarefoundation#538)

* port lanelet2 msg

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* port route

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix precommit

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Use route_handler package in mission_planner (autowarefoundation#579)

* [autoware_vehicle_rviz_plugin/route_handler/simple_planning_simulator]fix some packages (autowarefoundation#606)

* fix console meter

* fix velocity_history

* fix route handler

* change topic name

* Modify readme for mission planner (autowarefoundation#714)

* modify readme for mission planner

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* fix document

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* fix readme

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: kyoichi sugahara <81.s.kyo.19@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request May 16, 2022
…sary output (autowarefoundation#579)

* fix return value in l2 apply function

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* change turn_signal_decider output

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…sary output (tier4#579)

* fix return value in l2 apply function

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* change turn_signal_decider output

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…sary output (tier4#579)

* fix return value in l2 apply function

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* change turn_signal_decider output

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…sary output (tier4#579)

* fix return value in l2 apply function

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* change turn_signal_decider output

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jun 19, 2023
… is not zero (autowarefoundation#3971) (autowarefoundation#579)

* fix(avoidance): break if the shift line start longitudinal is less than zero



* feat(avoidance): check base offset before resetting of registered shift lines



---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
…warefoundation#579)

* start planner:new param: dist th to middle of road

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* refactor param order

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

---------

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants