Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): output manager internal state as topic #6099

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jan 17, 2024

Description

Output planner manager internal state as a topic.

Related PR: #6100

Screenshot from 2024-01-17 16-55-34

Tests performed

Psim

ros2 topic echo /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/debug/internal_state

Effects on system behavior

Output topic as /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/debug/internal_state

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 17, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review January 17, 2024 09:11
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 17, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) January 17, 2024 10:01
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0466378) 14.62% compared to head (2dba361) 14.65%.
Report is 6 commits behind head on main.

Files Patch % Lines
...ning/behavior_path_planner/src/planner_manager.cpp 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6099      +/-   ##
==========================================
+ Coverage   14.62%   14.65%   +0.02%     
==========================================
  Files        1858     1858              
  Lines      127059   127158      +99     
  Branches    37224    37303      +79     
==========================================
+ Hits        18585    18635      +50     
- Misses      87578    87593      +15     
- Partials    20896    20930      +34     
Flag Coverage Δ *Carryforward flag
differential 9.48% <0.00%> (?)
total 14.62% <ø> (-0.01%) ⬇️ Carriedforward from 0466378

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit b4b0002 into autowarefoundation:main Jan 17, 2024
36 of 39 checks passed
@satoshi-ota satoshi-ota deleted the feat/publish-internal-state branch January 17, 2024 23:17
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jan 18, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#6099)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2024
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants