-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_crosswalk_module): check if p_safety_slow is empty #6104
fix(behavior_velocity_crosswalk_module): check if p_safety_slow is empty #6104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could reproduce the original issue and with this PR it is fixed.
abd312a
to
5bcce2d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6104 +/- ##
==========================================
- Coverage 14.61% 14.61% -0.01%
==========================================
Files 1859 1859
Lines 127242 127243 +1
Branches 37275 37276 +1
==========================================
Hits 18598 18598
- Misses 87727 87728 +1
Partials 20917 20917
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: beyza <bnk@leodrive.ai>
5bcce2d
to
790f0f8
Compare
…pty (autowarefoundation#6104) * check if p_safety_slow is empty Signed-off-by: beyza <bnk@leodrive.ai> * style(pre-commit): autofix --------- Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…pty (autowarefoundation#6104) * check if p_safety_slow is empty Signed-off-by: beyza <bnk@leodrive.ai> * style(pre-commit): autofix --------- Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…pty (autowarefoundation#6104) * check if p_safety_slow is empty Signed-off-by: beyza <bnk@leodrive.ai> * style(pre-commit): autofix --------- Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: karishma <karishma@interpl.ai>
…pty (autowarefoundation#6104) * check if p_safety_slow is empty Signed-off-by: beyza <bnk@leodrive.ai> * style(pre-commit): autofix --------- Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…pty (autowarefoundation#6104) * check if p_safety_slow is empty Signed-off-by: beyza <bnk@leodrive.ai> * style(pre-commit): autofix --------- Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Fixes: #6102
Tests performed
p_safety_slow_is_empty.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.