Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_crosswalk_module): check if p_safety_slow is empty #6104

Conversation

beyzanurkaya
Copy link
Contributor

Description

Fixes: #6102

Tests performed

p_safety_slow_is_empty.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@beyzanurkaya beyzanurkaya self-assigned this Jan 17, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 17, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could reproduce the original issue and with this PR it is fixed.

@maxime-clem maxime-clem added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 17, 2024
@beyzanurkaya beyzanurkaya force-pushed the bnk/dev/behavior-planning-died branch from abd312a to 5bcce2d Compare January 17, 2024 11:54
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 17, 2024
@beyzanurkaya beyzanurkaya enabled auto-merge (squash) January 17, 2024 11:54
@beyzanurkaya beyzanurkaya removed the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 17, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c833bea) 14.61% compared to head (790f0f8) 14.61%.
Report is 4 commits behind head on main.

Files Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6104      +/-   ##
==========================================
- Coverage   14.61%   14.61%   -0.01%     
==========================================
  Files        1859     1859              
  Lines      127242   127243       +1     
  Branches    37275    37276       +1     
==========================================
  Hits        18598    18598              
- Misses      87727    87728       +1     
  Partials    20917    20917              
Flag Coverage Δ *Carryforward flag
differential 12.15% <0.00%> (?)
total 14.61% <ø> (+<0.01%) ⬆️ Carriedforward from c833bea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

beyza and others added 2 commits January 18, 2024 13:33
@beyzanurkaya beyzanurkaya force-pushed the bnk/dev/behavior-planning-died branch from 5bcce2d to 790f0f8 Compare January 18, 2024 10:33
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 18, 2024
@beyzanurkaya beyzanurkaya merged commit d1059e5 into autowarefoundation:main Jan 18, 2024
21 of 24 checks passed
yuki-takagi-66 pushed a commit to tier4/autoware.universe that referenced this pull request Feb 19, 2024
…pty (autowarefoundation#6104)

* check if p_safety_slow is empty

Signed-off-by: beyza <bnk@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@beyzanurkaya beyzanurkaya deleted the bnk/dev/behavior-planning-died branch March 5, 2024 09:33
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…pty (autowarefoundation#6104)

* check if p_safety_slow is empty

Signed-off-by: beyza <bnk@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…pty (autowarefoundation#6104)

* check if p_safety_slow is empty

Signed-off-by: beyza <bnk@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…pty (autowarefoundation#6104)

* check if p_safety_slow is empty

Signed-off-by: beyza <bnk@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…pty (autowarefoundation#6104)

* check if p_safety_slow is empty

Signed-off-by: beyza <bnk@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behavior_planning_container dies because of the crosswalk_module
3 participants