Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_localization_launch): use util.launch.xml instead of util.launch.py #6287

Conversation

YamatoAndo
Copy link
Contributor

Description

use util.launch.xml instead of util.launch.py

Tests performed

LSim works.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…til.launch.py

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@YamatoAndo
Copy link
Contributor Author

@reviewers
I believe I have modified util.launch.xml to behave the same as util.launch.py.
If there are any differences, please let me know in the comments.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 1, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 2, 2024
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️
I have confirmed that this pr works well in logging_simulator.launch.xml

@YamatoAndo YamatoAndo enabled auto-merge (squash) February 6, 2024 05:36
@YamatoAndo YamatoAndo merged commit b396413 into autowarefoundation:main Feb 6, 2024
16 of 17 checks passed
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…til.launch.py (autowarefoundation#6287)

* refactor(tier4_localization_launch): use util.launch.xml instead of util.launch.py

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…til.launch.py (autowarefoundation#6287)

* refactor(tier4_localization_launch): use util.launch.xml instead of util.launch.py

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…til.launch.py (autowarefoundation#6287)

* refactor(tier4_localization_launch): use util.launch.xml instead of util.launch.py

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants