chore(ndt scan matcher): rename config path #6333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…til.launch.py Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
github-actions
bot
added
the
component:launch
4 tasks
|
I will open this pr after merging #6287 |
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
YamatoAndo
requested review from
anhnv3991,
KYabuuchi,
kminoda,
RyuYamamoto,
SakodaShintaro and
TaikiYamada4
as code owners
Motsu-san
approved these changes
Feb 6, 2024
YamatoAndo
added
the
run:build-and-test-differential
SakodaShintaro
approved these changes
Feb 7, 2024
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
* refactor(tier4_localization_launch): use util.launch.xml instead of util.launch.py Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * chore(ndt_scan_matcher): rename config path Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * rename path Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
* refactor(tier4_localization_launch): use util.launch.xml instead of util.launch.py Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * chore(ndt_scan_matcher): rename config path Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * rename path Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with autowarefoundation/autoware_launch#854
Description
I renamed the config paths for clarity.
Tests performed
LSim works.
Effects on system behavior
config paths are renamed.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.