Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ndt_scan_matcher): rename config path #854

Conversation

YamatoAndo
Copy link
Contributor

Description

see autowarefoundation/autoware.universe#6333

Tests performed

see autowarefoundation/autoware.universe#6333

Effects on system behavior

see autowarefoundation/autoware.universe#6333

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@YamatoAndo YamatoAndo force-pushed the chore/ndt_scan_matcher/rename_config_path branch from 2762244 to ab9580e Compare February 6, 2024 08:58
@YamatoAndo YamatoAndo marked this pull request as ready for review February 6, 2024 14:03
Copy link
Contributor

@Motsu-san Motsu-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked along with this pair pull request,
LGTMeow

@YamatoAndo YamatoAndo merged commit 93fc83e into autowarefoundation:main Feb 7, 2024
9 of 10 checks passed
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jun 5, 2024
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 3, 2024
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants