-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove autoware_auto_geometry package #7217
Merged
mitsudome-r
merged 2 commits into
autowarefoundation:main
from
mitsudome-r:remove-autoware-auto-geometry
Jun 3, 2024
Merged
feat: remove autoware_auto_geometry package #7217
mitsudome-r
merged 2 commits into
autowarefoundation:main
from
mitsudome-r:remove-autoware-auto-geometry
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsudome-r
requested review from
miursh,
tzhong518 and
satoshi-ota
as code owners
June 2, 2024 06:24
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
labels
Jun 2, 2024
mitsudome-r
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 2, 2024
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
mitsudome-r
force-pushed
the
remove-autoware-auto-geometry
branch
from
June 2, 2024 06:28
ea92ca8
to
712f661
Compare
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7217 +/- ##
==========================================
+ Coverage 15.09% 15.61% +0.51%
==========================================
Files 1967 1983 +16
Lines 135941 137528 +1587
Branches 42122 44536 +2414
==========================================
+ Hits 20520 21471 +951
+ Misses 92700 92636 -64
- Partials 22721 23421 +700
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I need reviews from the following members:
|
satoshi-ota
approved these changes
Jun 3, 2024
miursh
approved these changes
Jun 3, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
* feat!: remove autoware_auto_geometry package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * docs: remove autoware_auto_geometry package from docs Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> --------- Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
* feat!: remove autoware_auto_geometry package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * docs: remove autoware_auto_geometry package from docs Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> --------- Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat!: remove autoware_auto_geometry package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * docs: remove autoware_auto_geometry package from docs Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> --------- Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #6893.
This removes unused package "autoware_auto_geometry" from Autoware.Universe.
This makes it easier to migrate from autoware_auto_msgs to autoware_msgs.
Related links
#6893
https://github.com/orgs/autowarefoundation/discussions/3482#discussioncomment-5929874
Tests performed
Build test passed on my local machine
Notes for reviewers
Although perception/traffic_light_occlusion_predictor/package.xml includes this as package dependency, it doesn't really use anything from autoware_auto_geometry package.
Interface changes
All libraries in autoware_auto_geometry packages will be removed
Effects on system behavior
Not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.