Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove autoware_auto_geometry package #7217

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jun 2, 2024

Description

This is part of #6893.

This removes unused package "autoware_auto_geometry" from Autoware.Universe.
This makes it easier to migrate from autoware_auto_msgs to autoware_msgs.

Related links

#6893
https://github.com/orgs/autowarefoundation/discussions/3482#discussioncomment-5929874

Tests performed

Build test passed on my local machine

Notes for reviewers

Although perception/traffic_light_occlusion_predictor/package.xml includes this as package dependency, it doesn't really use anything from autoware_auto_geometry package.

Interface changes

All libraries in autoware_auto_geometry packages will be removed

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jun 2, 2024
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 2, 2024
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the remove-autoware-auto-geometry branch from ea92ca8 to 712f661 Compare June 2, 2024 06:28
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.61%. Comparing base (3d849e9) to head (d140cf0).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7217      +/-   ##
==========================================
+ Coverage   15.09%   15.61%   +0.51%     
==========================================
  Files        1967     1983      +16     
  Lines      135941   137528    +1587     
  Branches    42122    44536    +2414     
==========================================
+ Hits        20520    21471     +951     
+ Misses      92700    92636      -64     
- Partials    22721    23421     +700     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.61% <ø> (+0.51%) ⬆️ Carriedforward from 9dcf81e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r
Copy link
Member Author

mitsudome-r commented Jun 2, 2024

I need reviews from the following members:

@mitsudome-r mitsudome-r merged commit 1b7c600 into autowarefoundation:main Jun 3, 2024
30 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* feat!: remove autoware_auto_geometry package

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* docs: remove autoware_auto_geometry package from docs

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

---------

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
* feat!: remove autoware_auto_geometry package

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* docs: remove autoware_auto_geometry package from docs

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

---------

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* feat!: remove autoware_auto_geometry package

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* docs: remove autoware_auto_geometry package from docs

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

---------

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants