feat!: remove autoware_auto_tf2 package #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
mitsudome-r
added
the
run:build-and-test-differential
github-actions
bot
added
type:documentation
|
I have made this a draft PR since it depends on #7217 and we don't want to merge this by mistake, but the PR is ready for review. |
mitsudome-r
changed the title
7 tasks
shmpwk
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
This should be merged after #7217 and autowarefoundation/autoware_tools#31.
LGTM in advance.
mitsudome-r
requested review from
soblin,
maxime-clem,
TakaHoribe,
tkimura4,
zulfaqar-azmi-t4,
satoshi-ota,
rej55,
isamu-takagi,
kyoichi-sugahara,
takayuki5168,
yuki-takagi-66,
danielsanchezaran,
go-sakayori and
kosuke55
as code owners
mitsudome-r
requested review from
TomohitoAndo,
miursh and
tzhong518
as code owners
github-actions
bot
removed
the
component:perception
maxime-clem
approved these changes
Jun 3, 2024
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
* feat!: remove autoware_auto_geometry package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * docs: remove autoware_auto_geometry package from docs Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * feat!: remove autoware_auto_tf2 package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * fix: remove from autoware_auto_tf2 packages from docs page Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> --------- Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
* feat!: remove autoware_auto_geometry package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * docs: remove autoware_auto_geometry package from docs Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * feat!: remove autoware_auto_tf2 package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * fix: remove from autoware_auto_tf2 packages from docs page Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> --------- Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat!: remove autoware_auto_geometry package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * docs: remove autoware_auto_geometry package from docs Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * feat!: remove autoware_auto_tf2 package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * fix: remove from autoware_auto_tf2 packages from docs page Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> --------- Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #6893.
This PR removes the unused autoware_auto_tf2 package from Autoware.Universe
This should be merged after #7217 and autowarefoundation/autoware_tools#31.
The package was originally made when the tf2 package in ROS 2 wasn't still mature enough, but many of the functions were migrated to the upstream and no packages depend on Autoware's tf2 package anymore. (example)
Related links
#6893
#7217
Tests performed
I have done the build test on my local machine
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.