fix(static_obstacle_avoidance): ignore pedestrian/cyclist who is not on road edge #7850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…on road edge Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
fix/improve-cyclist-filtering
branch
from
674f3df to
3fc9fd3
Compare
satoshi-ota
requested review from
rej55,
go-sakayori,
kyoichi-sugahara,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
github-actions
bot
added
the
type:documentation
satoshi-ota
added
the
run:deploy-docs
go-sakayori
approved these changes
Jul 5, 2024
...ning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/README.md
Show resolved
Hide resolved
…bstacle_avoidance_module/README.md Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
satoshi-ota
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7850 +/- ##
==========================================
- Coverage 28.66% 28.65% -0.01%
==========================================
Files 1588 1589 +1
Lines 116375 116415 +40
Branches 49688 49703 +15
==========================================
+ Hits 33357 33361 +4
- Misses 73907 73944 +37
+ Partials 9111 9110 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 8, 2024
…on road edge (autowarefoundation#7850) * fix(static_obstacle_avoidance): ignore pedestrian/cyclist who is not on road edge Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(static_obstacle_avoidance): update flowchart Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/README.md Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 9, 2024
…on road edge (autowarefoundation#7850) * fix(static_obstacle_avoidance): ignore pedestrian/cyclist who is not on road edge Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(static_obstacle_avoidance): update flowchart Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/README.md Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
Merged
4 tasks
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…on road edge (autowarefoundation#7850) * fix(static_obstacle_avoidance): ignore pedestrian/cyclist who is not on road edge Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(static_obstacle_avoidance): update flowchart Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/README.md Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…on road edge (autowarefoundation#7850) * fix(static_obstacle_avoidance): ignore pedestrian/cyclist who is not on road edge Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(static_obstacle_avoidance): update flowchart Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/README.md Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…on road edge (#7850) * fix(static_obstacle_avoidance): ignore pedestrian/cyclist who is not on road edge Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(static_obstacle_avoidance): update flowchart Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/README.md Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…on road edge (autowarefoundation#7850) * fix(static_obstacle_avoidance): ignore pedestrian/cyclist who is not on road edge Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(static_obstacle_avoidance): update flowchart Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/README.md Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As this module didn't have proper filtering flow for PEDESTRIAN and BICYCLE, sometimes it caused unnecessary avoidance maneuver. Therefor, I added new condition to ignore them if they are in intersection or stop on middle of the road.
simplescreenrecorder-2024-07-05_09.01.03.mp4
Related links
Parent Issue:
How was this PR tested?
simplescreenrecorder-2024-07-01_18.32.33.mp4
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.