-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_tensorrt_bevdet): add new 3d object detection method #7956
base: main
Are you sure you want to change the base?
feat(autoware_tensorrt_bevdet): add new 3d object detection method #7956
Conversation
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool PR 🚀
Let me provide some minor comments first. Also, please make sure that all the CIs are passing before opening the PR 🙏
@cyn-liu Please make sure that the node follows coding guildline: https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/class-design/ such as |
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
…e.universe into feat/add_tensorrt_bevdet Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
…e.universe into feat/add_tensorrt_bevdet Signed-off-by: liu cui <cynthia.liu@autocore.ai>
(Friendly ping 🙏 ) Would you mention us once all the CIs are fixed? |
I could see two required checks are not passed.
|
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
…e.universe into feat/add_tensorrt_bevdet Signed-off-by: liu cui <cynthia.liu@autocore.ai>
@cyn-liu As this PR is stale for a week, from the maintenance perspective, let me make this PR a draft for now. Feel free to re-open the PR once all the CIs are fixed and ready to be reviewed. Thank you for your understanding, and we are looking forward to reviewing your PR. |
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
…ernal bevdet_vendor library Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
…ck error Signed-off-by: liu cui <cynthia.liu@autocore.ai>
You should also update build_depends.repos which is used for the build-and-test CI. |
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
bc7d287
to
1a5038b
Compare
Signed-off-by: liu cui <cynthia.liu@autocore.ai>
1a5038b
to
4583652
Compare
Description
Integrating BEVDet into Autoware for 3D object detection based on multi-view images.
NEWS: Refactoring the integration method of bevdet-tensorrt-cpp to Autoware:
We wrap the original bevdet-tensorrt-cpp code as a vendor package and maintain it outside Autoware with different CIs settings and code standards. Then we added through autoware.repos and just call the libraries in
autoware_tensorrt_bevdet
node.NOTE: This PR depends on another PR fix(autoware.repos): add bevdet_vendor external package #5456
Related links
Issue Link
How was this PR tested?
This PR has been tested on local environment.
env1:
env2:
Notes for reviewers
Test using a bag containing Nuscenes data.
Note: The
frame_id
of/lidar_top
in this bag ismap
onnx model file
bag
Interface changes
Add a new
perception_mode
, If setperception_mode = camera
, the detector will launchtesnsorrt_bevdet
node.Topic changes
Additions and removals
~/input/topic_cloud
sensor_msgs::msg::PointCloud2
~/input/topic_img_fl
sensor_msgs::msg::Image
~/input/topic_img_f
sensor_msgs::msg::Image
~/input/topic_img_fr
sensor_msgs::msg::Image
~/input/topic_img_bl
sensor_msgs::msg::Image
~/input/topic_img_b
sensor_msgs::msg::Image
~/input/topic_img_br
sensor_msgs::msg::Image
~/output/painting_cloud
sensor_msgs::msg::PointCloud2
~/output/boxes
autoware_perception_msgs::msg::DetectedObjects
ROS Parameter Changes
Additions and removals
bev_detection_model
string
bevdet
Modifications
perception_mode
string
lidar
perception_mode
string
lidar
camera
Effects on system behavior
None.