Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_tensorrt_bevdet): add new 3d object detection method #7956

Open
wants to merge 97 commits into
base: main
Choose a base branch
from

fix: modify README.md

4583652
Select commit
Loading
Failed to load commit list.
Open

feat(autoware_tensorrt_bevdet): add new 3d object detection method #7956

fix: modify README.md
4583652
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 21, 2024 in 46s

CodeScene PR Check

Code Health Quality Gates: OK

Code Health of new files: 9.69

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments bevdet_node.cpp: TRTBEVDetNode::callback
  • Excess Number of Function Arguments ros_utils.cpp: box3DToDetectedObjects

Annotations

Check warning on line 186 in perception/autoware_tensorrt_bevdet/src/bevdet_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

TRTBEVDetNode::callback has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 101 in perception/autoware_tensorrt_bevdet/src/ros_utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

box3DToDetectedObjects has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.