Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_inteface): add function to check force deactivate #8200

Conversation

go-sakayori
Copy link
Contributor

Description

Current rtc interface could not judge whether cooperateStatus was force deactivated or not.
This PR enables to judge force deactivation (ex. deactivation from human operators).

Related links

How was this PR tested?

TIER IV internal test

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@go-sakayori go-sakayori changed the title feat (rtc_inteface): add function to check force deactivate feat(rtc_inteface): add function to check force deactivate Jul 26, 2024
@go-sakayori go-sakayori added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.24%. Comparing base (75477f7) to head (9183a9f).
Report is 2 commits behind head on main.

Files Patch % Lines
...nning/autoware_rtc_interface/src/rtc_interface.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8200   +/-   ##
=======================================
  Coverage   29.24%   29.24%           
=======================================
  Files        1600     1604    +4     
  Lines      117736   117774   +38     
  Branches    50718    50719    +1     
=======================================
+ Hits        34430    34447   +17     
- Misses      74114    74122    +8     
- Partials     9192     9205   +13     
Flag Coverage Δ *Carryforward flag
differential 19.85% <0.00%> (?)
total 29.25% <ø> (+0.01%) ⬆️ Carriedforward from 59836c7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants