Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_inteface): add function to check force deactivate #8221

Merged

Conversation

go-sakayori
Copy link
Contributor

Description

Current rtc interface could not judge whether cooperateStatus was force deactivated or not.
This PR enables to judge force deactivation (ex. deactivation from human operators).

Related links

How was this PR tested?

TIER IV internal test

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@go-sakayori go-sakayori changed the title feat(rtc_inteface): add function to check force deactivate feat(rtc_inteface): add function to check force deactivate Jul 26, 2024
@go-sakayori go-sakayori added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 26, 2024
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
@go-sakayori go-sakayori force-pushed the feat/rtc_interface_force_deactive branch from 9183a9f to 3c45b45 Compare July 26, 2024 09:47
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.25%. Comparing base (95aef0d) to head (3c45b45).

Files Patch % Lines
...nning/autoware_rtc_interface/src/rtc_interface.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8221      +/-   ##
==========================================
- Coverage   29.26%   29.25%   -0.02%     
==========================================
  Files        1600     1604       +4     
  Lines      117736   117774      +38     
  Branches    50708    50723      +15     
==========================================
- Hits        34450    34449       -1     
- Misses      74058    74136      +78     
+ Partials     9228     9189      -39     
Flag Coverage Δ *Carryforward flag
differential 19.85% <0.00%> (?)
total 29.25% <ø> (-0.01%) ⬇️ Carriedforward from 5c01a9a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@go-sakayori go-sakayori marked this pull request as ready for review July 26, 2024 10:34
@go-sakayori
Copy link
Contributor Author

go-sakayori commented Jul 26, 2024

@satoshi-ota
Same content as this closed PR.
Now this time the CI seemes to work! (It didn't work for 2 hours in the previous PR)
May be it was a problem with the disk space.

@go-sakayori go-sakayori merged commit 687aa93 into autowarefoundation:main Jul 29, 2024
28 of 30 checks passed
@go-sakayori go-sakayori deleted the feat/rtc_interface_force_deactive branch July 29, 2024 00:36
go-sakayori added a commit to tier4/autoware.universe that referenced this pull request Aug 2, 2024
…oundation#8221)

add function to check for deactivation

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
go-sakayori added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2024
…oundation#8221)

add function to check for deactivation

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…oundation#8221)

add function to check for deactivation

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Aug 20, 2024
…oundation#8221)

add function to check for deactivation

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Aug 20, 2024
…oundation#8221)

add function to check for deactivation

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2025
…oundation#8221)

add function to check for deactivation

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants