fix(autoware_carla_interface): resolve init file error and colcon marker warning #9115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:simulation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
maxime-clem
added
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9115 +/- ##
=======================================
Coverage 27.50% 27.50%
=======================================
Files 1303 1303
Lines 101046 101046
Branches 39180 39180
=======================================
Hits 27794 27794
Misses 70544 70544
Partials 2708 2708
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…dules directories - Added __init__.py to autoware_carla_interface to ensure it is treated as a Python package. - Added __init__.py to the modules directory for proper subpackage handling. Signed-off-by: Jesus Armando Anaya <jesus@armandoanaya.com>
…er warning - Renamed the resource file to `autoware_carla_interface` as required for ROS 2 package indexing. - Updated `setup.py` to include the correct marker file path in `data_files`, resolving the colcon warning about missing explicit markers in the ament resource index. Signed-off-by: Jesus Armando Anaya <jesus@armandoanaya.com>
JesusAnaya
force-pushed
the
fix/missing-init-py-autoware-carla-interface
branch
from
b336d87 to
3a8aedb
Compare
JesusAnaya
requested review from
danielsanchezaran,
kosuke55 and
takayuki5168
as code owners
github-actions
bot
added
the
component:evaluator
JesusAnaya
force-pushed
the
fix/missing-init-py-autoware-carla-interface
branch
from
d3b7386 to
3a8aedb
Compare
github-actions
bot
removed
the
component:evaluator
maxime-clem
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the colcon warning and errors in the
autoware_carla_interfacepackage:autoware_carla_interfacefor proper ROS 2 package indexing.__init__.pyfiles for Python package recognition, which previously caused the following error:package init file 'src/autoware_carla_interface/__init__.py' not found (or not a regular file).WARNING:colcon.colcon_ros.task.ament_python.build: Package 'autoware_carla_interface' doesn't explicitly install a marker in the package index.Related links
Parent Issue:
How was this PR tested?
Build and colcon test for the
autoware_carla_interfacemodule, verifying that the marker warning and colcon errors are resolved.Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.