[fix] Install commands for all the packages #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amc-nu
changed the title
3 tasks
2 tasks
* Remove devel directory from catkin, if any
* Added launch install to lidar_kf_contour_track * Added install to op_global_planner * Added install to way_planner * Added install to op_local_planner * Added install to op_simulation_package * Added install to op_utilities * Added install to sync
amc-nu
changed the title
* Fixed nodelet error for gmsl cameras
Merged
* Fixed installation path * Fixed params installation path * Fixed cfg installation path
There was a problem hiding this comment.
@amc-nu I have seen that some of the packages are not installing the include directory. Can be assumed that the header files for those packages are not to be installed?
|
@sgermanserrano indeed. Only libraries that are used outside its own node are installing headers. |
sgermanserrano
approved these changes
Feb 15, 2019
|
@sgermanserrano thank you so much for testing.! I’ll merge once I test the ouster submodule. Which is also missing install commands. |
|
Fixed ouster as well |
36 tasks
17 tasks
anubhavashok
pushed a commit
to NuronLabs/autoware.ai
that referenced
this pull request
Sep 7, 2021
* Initial fixes to detection, sensing, semantics and utils * fixing wrong filename on install command * Fixes to install commands * Hokuyo fix name * Fix obj db * Obj db include fixes * End of final cleaning sweep * Incorrect command order in runtime manager * Param tempfile not required by runtime_manager * * Fixes to runtime manager install commands * Remove devel directory from catkin, if any * Updated launch files for robosense * Updated robosense * Fix/add missing install (autowarefoundation#1977) * Added launch install to lidar_kf_contour_track * Added install to op_global_planner * Added install to way_planner * Added install to op_local_planner * Added install to op_simulation_package * Added install to op_utilities * Added install to sync * * Improved installation script for pointgrey packages * Fixed nodelet error for gmsl cameras * USe install space in catkin as well * add install to catkin * Fix install directives (autowarefoundation#1990) * Fixed installation path * Fixed params installation path * Fixed cfg installation path * Delete cache on colcon_release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
PRODUCTION / DEVELOPMENT
Description
autowarefoundation/autoware_ai#491
Required by autowarefoundation/autoware_ai#476
Requires autowarefoundation/autoware_ai#389 autowarefoundation/autoware_ai#475