Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE YET][Fix] Revert b21b663 #1902

Closed
wants to merge 10 commits into from
Closed

Conversation

kfunaoka
Copy link

@kfunaoka kfunaoka commented Jan 17, 2019

Status

DEVELOPMENT

Description

Revert b21b663

This pull request is created by

$ git checkout release/1.10.0_back_to_develop
$ git checkout -b feature/revert_b21b663
$ git revert b21b663

# Select ours (=develop)
$ git rm ros/src/computing/perception/detection/lidar_detector/packages/lidar_svm_detect/CMakeLists.txt ros/src/computing/perception/detection/lidar_tracker/packages/lidar_kf_track/CMakeLists.txt ros/src/computing/perception/detection/lidar_tracker/packages/obj_fusion/CMakeLists.txt ros/src/computing/perception/detection/lidar_tracker/packages/obj_reproj/CMakeLists.txt ros/src/computing/perception/detection/vision_tracker/libs/kf/CMakeLists.txt ros/src/computing/perception/detection/vision_tracker/packages/vision_dummy_track/CMakeLists.txt ros/src/computing/perception/detection/vision_tracker/packages/vision_klt_track/CMakeLists.txt ros/src/computing/planning/state/state_machine/CMakeLists.txt ros/src/sensing/fusion/packages/calibration_camera_lidar/CMakeLists.txt ros/src/sensing/fusion/packages/scan2image/CMakeLists.txt

$ git commit -m "Revert b21b663"
$ git push upstream feature/revert_b21b663

Related PRs

#1901
#1861

Todos

@kfunaoka kfunaoka changed the title [Fix] Revert b21b663 [DO NOT MERGE][Fix] Revert b21b663 Jan 17, 2019
@kfunaoka kfunaoka changed the title [DO NOT MERGE][Fix] Revert b21b663 [DO NOT MERGE YET][Fix] Revert b21b663 Jan 17, 2019
@kfunaoka kfunaoka mentioned this pull request Jan 17, 2019
5 tasks
@gbiggs
Copy link

gbiggs commented Mar 18, 2019

@kfunaoka What's up with this PR? Should it be closed?

@gbiggs gbiggs added type:bug Software flaws or errors. in review labels Mar 18, 2019
@amc-nu
Copy link
Member

amc-nu commented Mar 18, 2019

We can safely close this. Superseeded by #1990 #1861 #1977

@amc-nu amc-nu closed this Mar 18, 2019
@amc-nu amc-nu deleted the feature/revert_b21b663 branch March 18, 2019 05:49
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors. version:autoware-ai Autoware.AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants