Feature/nmea to mgrs #1878
Feature/nmea to mgrs #1878
Conversation
There was a problem hiding this comment.
This is a great addition @mitsudome-r
@kfunaoka can you please tell @mitsudome-r how to add unit tests before approving?
@kitsukawa could you check the conversion of the nmea messages?
|
@kfunaoka also please show him how to apply clang format. |
| @@ -1,7 +1,7 @@ | |||
| cmake_minimum_required(VERSION 2.8.3) | |||
| project(gnss) | |||
|
|
|||
| find_package(catkin REQUIRED COMPONENTS roscpp) | |||
| find_package(catkin REQUIRED COMPONENTS roscpp geodesy) | |||
There was a problem hiding this comment.
you'll need to add an IF to don't compile this on ARM architectures, this package is not available.
There was a problem hiding this comment.
really?
I used geodesy in Jetson TX2 by using rosdep.
There was a problem hiding this comment.
Then, please have a look at the log of GitlabCi which is failing the arm build.
|
Looks like #1305 does the similar conversion from lat/lon to mgrs xyz and is done without external package (although it is for pcd). |
|
For the time being, I will close this PR and create new one when the changes are made. |
Status
DEVELOPMENT
Description
Add conversion from nmea_sentence to MGRS xyz coordinate for
・fix2tfpose
・nmea2tfpose
Related Issues
autowarefoundation/autoware_ai#499
Todos
Steps to Test or Reproduce
NOTE
Currently, only UTM is supported and it cannot convert nmea->MGRS near north or south pole.
New dependency to geodesy is added to geo_pos_conv library.