Feature/update health checker threashold by rosparam #2104
Conversation
There was a problem hiding this comment.
@hakuturu583 why are there some many different files changed for what it seems from the PR description as a minor bug fix?
|
This PR is unmergable. There are far too many unrelated changes, such as header file name changes. Please make every change that is intended for a new PR in its own individual branch. Also please make the PR description is complete and detailed. |
|
This PR adds ValueManager Class to the autoware_health_checker.
|
|
ValueManager get threashold parameter from rosparam. |
|
@hakuturu583 as per autowarefoundation/autoware_ai#494 can you create a ReadMe for the feature?, there seem to be a lot of things that need to be manually done to get it to work. Also how is this different from bond? |
|
@sgermanserrano It is not only heart beat. Heartbeat feature is includes in PR #1943 |
|
@sgermanserrano OK! I will add README.md |
|
|
||
| // still send is true | ||
| bool send_emergency_cmd = false; | ||
| }; |
There was a problem hiding this comment.
This class is already defined in twist_gate.h.
|
@hakuturu583 If this is not going into 1.11, please move it to a fork. |
gbiggs
added
type:new-feature
|
@gbiggs I already forked this feature branch!! |
|
Please link to the new PR. |
Status
DEVELOPMENT*
Description
autowarefoundation/autoware_ai#605
Steps to Test or Reproduce
you should set /enable_statistisc rosparam before you launch all nodes
update default.yaml in autoware_health_checker and