Ensure scripts/lint.sh failure when used with incompatible grep #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/lint.sh requires the use of GNU grep due to dependency on the `--perl-regexp` flag, and the default version installed on MacOS is not compatible. Previously this compatibility problem wasn't resulting in script failure due to how bash ignores `set -o errexit` when running commands in conditionals. Adding an explicit compatibility check ensures an obvious failure mode and path to resolution.
StephenButtolph
approved these changes
Jul 11, 2023
joshua-kim
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
scripts/lint.sh requires the use of GNU grep due to dependency on the
-P / --perl-regexpflag, and the default version installed on MacOS is not compatible. Previously this compatibility problem wasn't resulting in script failure due to how bash ignoresset -o errexitwhen running commands in conditionals. Adding an explicit compatibility check ensures an obvious failure mode and path to resolution.How this works
Running
grep -Pwith a regex that is guaranteed to match will succeed for gnu grep and fail with an informative message with macos' default grep.How this was tested