Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure scripts/lint.sh failure when used with incompatible grep #1711

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Ensure scripts/lint.sh failure when used with incompatible grep #1711

merged 3 commits into from
Jul 11, 2023

Commits on Jul 11, 2023

  1. Ensure scripts/lint.sh failure when used with incompatible grep 

    scripts/lint.sh requires the use of GNU grep due to dependency on the
`--perl-regexp` flag, and the default version installed on MacOS is
not compatible. Previously this compatibility problem wasn't resulting
in script failure due to how bash ignores `set -o errexit` when
running commands in conditionals. Adding an explicit compatibility
check ensures an obvious failure mode and path to resolution.
    @marun
    marun committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    62a7472 View commit details
    Browse the repository at this point in the history

  2. fixup: message wording

    @marun
    marun committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    1e2da87 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into lint-fail-incompatible-grep

    @StephenButtolph
    StephenButtolph committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b3234c4 View commit details
    Browse the repository at this point in the history