Restrict Owner usage after a Subnet manager is set
#3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
dhrubabasu
changed the title
Owner usage after a Subnet manager is set
marun
reviewed
Aug 13, 2024
marun
approved these changes
Aug 14, 2024
dhrubabasu
commented
Aug 14, 2024
StephenButtolph
approved these changes
Aug 19, 2024
StephenButtolph
deleted the
disable-permissioned-subnet-txs-post-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
ACP-77 calls for disabling all transactions that uses
SubnetAuthother thanTransferSubnetOwnershipTxwhen a Subnet sets a manager.How this works
There are 5 transactions that have
SubnetAuthas a field:This PR considers the first three invalid if a Subnet has a manager that is set.
The execution of TransformSubnetTx does not need to be modified as it is already disabled post-Etna: #3152
How this was tested
added UTs